Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change case of TOC text #414

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Change case of TOC text #414

merged 1 commit into from
Jul 13, 2023

Conversation

james-nash
Copy link
Contributor

A content review of some Salt website pages flagged the capitalization of the "On this Page" heading above the TOC links. As per our writing style guide (available on the JPM-internal UI Toolkit site), we use sentence case for page titles and headings, so it should read: "On this page" (note the lowercase 'p').

This PR fixes that and also corrects the capitalization on the aria-label on the <ul> too.

@james-nash james-nash requested a review from a team as a code owner July 13, 2023 13:32
@vercel
Copy link

vercel bot commented Jul 13, 2023

@james-nash is attempting to deploy a commit to the mosaic-dev-team Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

⚠️ No Changeset found

Latest commit: 73af990

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5543727044

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.246%

Totals Coverage Status
Change from base Build 5543247640: 0.0%
Covered Lines: 1305
Relevant Lines: 1801

💛 - Coveralls

@DavieReid
Copy link
Contributor

Thanks for the fix, this is indeed something we need to change.

just to be clear, mosaic does not adhere to any JPM-internal UI Toolkit site writing style guide at this time.

@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mosaic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 1:48pm

@DavieReid DavieReid merged commit 93dd767 into jpmorganchase:main Jul 13, 2023
5 of 7 checks passed
@james-nash
Copy link
Contributor Author

Thanks for the quick review & merge!

just to be clear, mosaic does not adhere to any JPM-internal UI Toolkit site writing style guide at this time.

Fair enough. I was thinking longer term, it might be best to make any text like that configurable via a prop (could be useful for sites that want to use a language other than English too), but wanted to keep things simple for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants