-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change case of TOC text #414
Conversation
@james-nash is attempting to deploy a commit to the mosaic-dev-team Team on Vercel. A member of the Team first needs to authorize it. |
|
Pull Request Test Coverage Report for Build 5543727044
💛 - Coveralls |
Thanks for the fix, this is indeed something we need to change. just to be clear, mosaic does not adhere to any JPM-internal UI Toolkit site writing style guide at this time. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for the quick review & merge!
Fair enough. I was thinking longer term, it might be best to make any text like that configurable via a prop (could be useful for sites that want to use a language other than English too), but wanted to keep things simple for now. |
A content review of some Salt website pages flagged the capitalization of the "On this Page" heading above the TOC links. As per our writing style guide (available on the JPM-internal UI Toolkit site), we use sentence case for page titles and headings, so it should read: "On this page" (note the lowercase 'p').
This PR fixes that and also corrects the capitalization on the
aria-label
on the<ul>
too.