Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting started #412

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Getting started #412

merged 1 commit into from
Jul 13, 2023

Conversation

DavieReid
Copy link
Contributor

Updates to ensure site generator works and is windows compatible

@DavieReid DavieReid requested a review from a team as a code owner July 13, 2023 10:44
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4dca698

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mosaic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 0:37am

DavieReid
DavieReid commented Jul 13, 2023
View reviewed changes
packages/create-site/bin/mosaic-create-site.js Outdated
@@ -43,9 +43,6 @@ async function readMosaicConfig(mosaicConfigPath) {
await init({ silent: true });
}
try {
const nodeModulesPathRegexp = /(.*\/node_modules\/)/;
const nodeModulesPathMatches = __filename.match(nodeModulesPathRegexp);
process.env.NODE_PATH = `${process.env.NODE_PATH}${path.delimiter}${nodeModulesPathMatches[1]}`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-tate @joshwooding

I don't know why we are doing this...can you shed any light?

It breaks the site generator on windows and removing seems to get everything working on mac and windows

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly tried commenting these line in npx install location, it will not be able to find mosaicConfig

@coveralls
Copy link

coveralls commented Jul 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5543134504

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.246%
Totals Coverage Status
Change from base Build 5542228753: 0.0%
Covered Lines: 1305
Relevant Lines: 1801
💛 - Coveralls

@DavieReid DavieReid merged commit 42cbca5 into main Jul 13, 2023
7 checks passed
@DavieReid DavieReid deleted the getting-started branch July 13, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@origami-z origami-z origami-z left review comments

@mark-tate mark-tate mark-tate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavieReid @coveralls @mark-tate @origami-z