Added automatic mode selection #2168
Conversation
TwoOfTwelve
requested review from
Kr0nox and
tsaglam
and removed request for
Kr0nox
Co-authored-by: Alex | Kronox <[email protected]>
|
Adapt readme |
|
Also update the documentation JPlag/docs/1.-How-to-Use-JPlag.md Lines 120 to 130 in 10306cc Inspiration may be found here #2171 or just redirect to that section |
tsaglam
added
enhancement
|
| return; | ||
| } | ||
|
|
||
| if (inputs.size() == 1 && inputs.getFirst().getName().endsWith(ZIP_FILE_ENDING)) { |
There was a problem hiding this comment.
add a small comment what happens here, why we give an input file to the that is normally a submission to the viewer
| @@ -9,59 +9,95 @@ The language can either be set with the -l parameter or as a subcommand. If both | |||
| When using the subcommand, language-specific arguments can be set. | |||
| A list of language-specific options can be obtained by requesting the help page of a subcommand (e.g., "jplag java -h"). | |||
|
|
|||
| To open an existing report run: `java -jar jplag.jar </path/to/report.zip>` | |||
There was a problem hiding this comment.
I would also name the command you have above again here, to have them grouped better
java -jar jplag.jar path/to/the/submissions
There was a problem hiding this comment.
There are many changes here (and in the docs) due to the formatting of it changing. Is that due to the help text generation of picocli having changed?
Adds an implicit mode selection. The CLI will now detect the mode based on the input files.
From the documentation of the mode flag:
By default JPlag will automatically select the mode based on your input files. If none are selected the viewer will open on the file select screen. If a single result zip is selected it will be opened in the viewer directly. Otherwise JPlag will run on the submissions in the input files and show the result in the viewer.