Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default vite port #2157

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Use default vite port #2157

merged 1 commit into from
Jan 24, 2025

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jan 23, 2025

After the change from webpack to vite we still kept the old 8080 port. Vite per default uses 5173 for dev and 4173 for preview. This PR updates to those ports

@Kr0nox Kr0nox requested a review from sebinside January 23, 2025 18:07
@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Jan 23, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Jan 24, 2025
@tsaglam tsaglam merged commit 68a2d02 into develop Jan 24, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

@sebinside sebinside Awaiting requested review from sebinside

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kr0nox @tsaglam