Add ability to open old report viewers #2085
Open
+1,277
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kr0nox
added
enhancement
|
I would not include all old versions of the viewer. I'd suggest that it only shows something like "Please use JPlag vX.Y" and then a user can download the resp. version of JPlag |
I agree; I think until including 4.2.0 should be enough... |
TwoOfTwelve
approved these changes
Dec 10, 2024
|
|
tsaglam
requested changes
Jan 23, 2025
Comment on lines
+22
to
+26
| const bodyContent = await page.locator('body').textContent() | ||
| expect(bodyContent).toContain('You are trying to open a report from an older version of JPlag') | ||
| expect(bodyContent).toContain(oldVersion.version) | ||
| expect(bodyContent).toContain('You can access the old report viewer here:') | ||
| expect(bodyContent).toContain('Open old report viewer') |
There was a problem hiding this comment.
Suggested change
| const bodyContent = await page.locator('body').textContent() | |
| expect(bodyContent).toContain('You are trying to open a report from an older version of JPlag') | |
| expect(bodyContent).toContain(oldVersion.version) | |
| expect(bodyContent).toContain('You can access the old report viewer here:') | |
| expect(bodyContent).toContain('Open old report viewer') | |
| const bodyContent = await page.locator('body').textContent() | |
| expect(bodyContent).toContain('You are trying to open a report created with an older version of JPlag') | |
| expect(bodyContent).toContain(oldVersion.version) | |
| expect(bodyContent).toContain('You can still view this report here:') | |
| expect(bodyContent).toContain('Open with old report viewer') |
Comment on lines
+19
to
+29
| <div class="space-y-2"> | ||
| <h3 class="text-2xl font-bold"> | ||
| You are trying to open a report from an older version of JPlag | ||
| </h3> | ||
| <p class="text-xl"> | ||
| The report you are trying to open has version {{ uploadedVersion.toString() }}. <br /> | ||
| The current version of JPlag is {{ reportViewerVersion.toString() }}. The report viewer | ||
| can open reports from version {{ minimalReportVersion.toString() }}<br /> | ||
| You can access the old report viewer here: | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
Suggested change
| <div class="space-y-2"> | |
| <h3 class="text-2xl font-bold"> | |
| You are trying to open a report from an older version of JPlag | |
| </h3> | |
| <p class="text-xl"> | |
| The report you are trying to open has version {{ uploadedVersion.toString() }}. <br /> | |
| The current version of JPlag is {{ reportViewerVersion.toString() }}. The report viewer | |
| can open reports from version {{ minimalReportVersion.toString() }}<br /> | |
| You can access the old report viewer here: | |
| </p> | |
| </div> | |
| <div class="space-y-2"> | |
| <h3 class="text-2xl font-bold"> | |
| You are trying to open a report created with an older version of JPlag | |
| </h3> | |
| <p class="text-xl"> | |
| Your report was created with JPlag version {{ uploadedVersion.toString() }}. <br /> | |
| The current version of JPlag is {{ reportViewerVersion.toString() }}. It supports reports starting from version {{ minimalReportVersion.toString() }}<br /> | |
| You can still view the old report here: | |
| </p> | |
| </div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to open report viewers for older versions in local mode.
When a zip from a version that is not supported by the newest viewer gets uploaded, the user gets redirected to a seperate view that informs the user of this and offers them to open the viewer supports the report.
This PR currently only includes the report viewer that was published with version 5.1.0, which accepts reports dating back to version 4.2.0. Should a report viewer that accepts results from versions 4.0.0 and 4.1.0 also be included?
View for opening old versions
relates to #1190