Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new framework for Cli-Tests #1744

Merged
merged 10 commits into from
Jun 20, 2024
Merged

Added new framework for Cli-Tests #1744

merged 10 commits into from
Jun 20, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

This PR contains a new framework for cli tests. With this new framework it is possible to test the new cli more intuitive and check different artifacts than the options.

@TwoOfTwelve TwoOfTwelve requested review from tsaglam and Kr0nox May 2, 2024 10:42
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change labels May 3, 2024
@tsaglam

This comment was marked as outdated.

@TwoOfTwelve

This comment was marked as outdated.

Copy link
Member

@Kr0nox Kr0nox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small details

cli/src/test/java/de/jplag/cli/test/CliTest.java Outdated Show resolved Hide resolved
cli/src/test/java/de/jplag/cli/test/CliTest.java Outdated Show resolved Hide resolved
cli/src/test/java/de/jplag/cli/ClusteringTest.java Outdated Show resolved Hide resolved
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few issues and one minor sonar issue.

cli/src/test/java/de/jplag/cli/test/CliArgBuilder.java Outdated Show resolved Hide resolved
cli/src/test/java/de/jplag/cli/test/CliResult.java Outdated Show resolved Hide resolved
cli/src/test/java/de/jplag/cli/test/CliArg.java Outdated Show resolved Hide resolved
cli/src/test/java/de/jplag/cli/test/CliArg.java Outdated Show resolved Hide resolved
cli/src/test/java/de/jplag/cli/test/CliArgBuilder.java Outdated Show resolved Hide resolved
cli/src/test/java/de/jplag/cli/test/CliTest.java Outdated Show resolved Hide resolved
@tsaglam tsaglam added this to the 6.0.0 milestone May 27, 2024
@TwoOfTwelve TwoOfTwelve requested review from tsaglam and Kr0nox June 5, 2024 09:42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make these changes to the package-lock on purpose? running npm i readds the lines removed/changed.
If this was not on purpose, please revert the changes (you can simply run npm i and commit that)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the file. However, npm i didn't do that for me. In fakt, running npm i is what caused these changes in the first place.

@TwoOfTwelve TwoOfTwelve requested a review from Kr0nox June 18, 2024 07:56
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam
Copy link
Member

tsaglam commented Jun 19, 2024

There were still conflicts for the package lock, I resolved them by overriding with develop.

Copy link

@tsaglam tsaglam merged commit 90bc0db into develop Jun 20, 2024
44 checks passed
@tsaglam tsaglam deleted the feature/cliTests branch June 20, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants