-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new framework for Cli-Tests #1744
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small details
cli/src/test/java/de/jplag/cli/OldNewRootDirectoriesArgumentTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few issues and one minor sonar issue.
report-viewer/package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you make these changes to the package-lock on purpose? running npm i
readds the lines removed/changed.
If this was not on purpose, please revert the changes (you can simply run npm i
and commit that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the file. However, npm i didn't do that for me. In fakt, running npm i is what caused these changes in the first place.
Quality Gate passed for 'JPlag Report Viewer'Issues Measures |
There were still conflicts for the package lock, I resolved them by overriding with develop. |
…re/cliTests # Conflicts: # report-viewer/package-lock.json
Quality Gate passed for 'JPlag Plagiarism Detector'Issues Measures |
This PR contains a new framework for cli tests. With this new framework it is possible to test the new cli more intuitive and check different artifacts than the options.