Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Old cpp language names not found #1567

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix: Old cpp language names not found #1567

merged 1 commit into from
Feb 16, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Feb 16, 2024

Due to #1496 cpp results from <5.0.0 could not be read. this fixes it

@Kr0nox Kr0nox added bug Issue/PR that involves a bug report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Feb 16, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@uuqjz
Copy link
Contributor

uuqjz commented Feb 16, 2024

Can you open results from both datasets that i send you and view the actual comparisons?

@Kr0nox
Copy link
Member Author

Kr0nox commented Feb 16, 2024

Yes, I could open the result files of both datasets with both version 4.3.0 and 5.0.0. Regarding the not being able to open some submissions problem, I am trying to fix that and will open a different PR

@tsaglam tsaglam merged commit d246d6d into develop Feb 16, 2024
16 checks passed
@tsaglam tsaglam deleted the bug-fix/old-cpp branch February 16, 2024 13:47
@tsaglam tsaglam added the minor Minor issue/feature/contribution/change label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants