Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: absURL to relURL #81

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Conversation

pacollins
Copy link
Collaborator

Description

Change all absURL to relURL

Motivation and Context

Fixes #80

How Has This Been Tested?

Hugo Version: v0.3

Browser(s): Chrome

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@pacollins pacollins merged commit ddd8a16 into jpescador:master Nov 7, 2017
@pacollins pacollins deleted the patch-urls branch November 7, 2017 21:02
@pacollins pacollins restored the patch-urls branch November 7, 2017 21:24
@VeitSanner
Copy link

@pacollins, maybe my description has not been accurate enough. This applies not only to the links in header.html and footer.html where actually absURL ist used but also to sitebar.html and other places where the absolute URL is used.

@pacollins
Copy link
Collaborator Author

@VeitSanner - I actually had to revert because I noticed this, had to drive home and was going to address this in your thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of absURL for internal links prevents hostname changes
2 participants