-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilanguage #58
Multilanguage #58
Conversation
Add Multilanguage to ml-branch
Text translations
…formspree automatic emails.
Want to get a couple reviews from people to confirm this is working properly before merging. |
I am so far behind with staying up to date to this (thanks Teaching Practicum). Can anyone @statnmap or @blgo give me a quick status update? Are all the templates updated for ML? |
Pagination translatios NavBar dynamic titles translations: * taxonomies need i18n translation to display "Categories" translations * category taxonomy terms do not need a translation because this will be should be already translated for each language in their respective *.lang.md file. Translations to category taxonomy templates
There is still some discussion around the language switch design, but apart from that I am awaiting for my 3 pull requests to be merged into Multilanguage I have merged all my pull requests on top of statnmap's multilanguage branch and this is the result: Everything that does not belong to a content markdown file is now translated. |
Add Polish language
Once you have a look at these two PR, I would suggest to merge the multilanguage PR into the master, because all following modifications of your code may be different using the multilanguage. I think about relURl and relLangURL for instance. As well as some translations. |
@pacollins
I think we may warn the template users that if they use custom taxonomies, they will have to add them in the i18n files like category/categories. |
@statnmap and @blgo Sorry, I have fallen behind on this. I will review this all this weekend. Maybe we should look into an svg flag set that can be included with ML sites, but left out of regular sites? I have stumbled on flag-icon-css or semantic-ui flags - just the css is located at That might add some clarity to the menu to free up space to add a down arrow. I'm impartial to sprite vs SVG. EDIT: Since it seems we are really close, I am going to freeze all PRs until this is finished. I know that, since this is rather large, it can be hard to keep making updates based on things on the master. |
Sorry to double post. @statnmap, can you change the base branch of this PR to the new multilingual branch? I will be able to expedite its merge which will allow us to work on smaller chunks with more clarity which should help make the final push into the master. EDIT: I realized I am powerful in this Repo and could do that myself. 😆 Pending comments from either of you, I will merge this into the new branch for easier and clearer testing. |
I think the project is mature enough to be merged, despite some minor previous comments. |
This allows for translation in custom languages.
i18n
. A French translation is also provided.