-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meson Build File For Issue: #78 #119
Conversation
Included line for removal of Strict ANSI for pending bug fix in jpbruyere#78
Removed |
Test cases are now working properly and now onto GLSL shader compilation stage and inclusion. |
Added search for GLSLC and XXD softwares
Finished the shader compilation for both Linux/Windows, will have to test Windows later on. All that is left is documentation. |
Also added test related option to hide the warnings from test cases, this is set to true by default (non-test code still have warnings displayed.) |
All set for review! |
…KH once initial meson build is merged.
Strict ansi exclusion is removed, for more info on what is going on: #78 (comment) |
@@ -96,8 +97,82 @@ if `glslc` or `xxd` are not present, a precompiled version of the shaders is sto | |||
<a href="https://aur.archlinux.org/packages/vkvg"><img src="https://img.shields.io/aur/version/vkvg"></a> | |||
<a href="https://mpr.hunterwittenborn.com/packages/vkvg"><img src="https://img.shields.io/badge/mpr-v0.3.0--beta-blue"></a> | |||
|
|||
## Meson Build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more level from 'building' (an additional '#'), also I would have preferred the meson build to appear after the original cmake. (at least for now).
The VMA options should be splited in a separated markdown file (in the doc folder).
Is it possible to replace the shader/helper batches by commands directly issued from the meson build file? |
I also guess vkh stuff (including vma) will be moved to the vkhelpers project? |
Yep, there would still be some configuration options retained on this Vkvg project, that can be passed over to Vkh project for meson options. |
Thank you for your time on this... |
I will reopen this PR when I get it cleaned up and hopefully getting confirmation from Tinycthread on the undefine line. |
The scope of this Meson Build project is to migrate from CMake to Meson build system and to ensure it have the same or comparable feature parities to that of CMake. There are few additional configuration options such as modifying VMA defines to affect the memory allocation behaviors in Vulkan and so forth. There are some clear advantages to this meson file being clearer to write and to be easily imported into another Meson-based projects and potentially CMake as well through Pkg-config manifest. Existing meson project can import declared dependencies such as
vkvg_shared_dep
andvkvg_static_dep
.Pending Tasks to Complete:
VMA_DEFAULT_LARGE_HEAP_BLOCK_SIZE
)