Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Plausible analysis service #584

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Conversation

DejavuMoe
Copy link
Contributor

Plausible is a simple, privacy-friendly alternative to Google Analytics, in this Pr:

  • Add Plausible analysis script, but not enabled by default
  • Add configuration fields for Plausible analysis in params.toml
  • Support users to use Plausible management deployment or self-hosting services in params.toml
  • Add the appropriate description to the document

@netlify
Copy link

netlify bot commented Jun 16, 2023

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 467ebf9
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/64992f35c9cf110008117b68
😎 Deploy Preview https://deploy-preview-584--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jpanther jpanther added the enhancement New feature or request label Jun 17, 2023
@jpanther
Copy link
Owner

Thanks for the PR, @DejavuMoe! I'm happy to look at adding this to the theme as it's a broadly useful feature. Is it possible to refactor this so that the enable config flag is not required? ie. Could it work in a similar way to how Fathom Analytics or Google Analytics works in that when you provide a site ID/domain it then knows to include the code. It would provide for a more consistent user experience.

@DejavuMoe
Copy link
Contributor Author

Thanks for the PR, @DejavuMoe! I'm happy to look at adding this to the theme as it's a broadly useful feature. Is it possible to refactor this so that the enable config flag is not required? ie. Could it work in a similar way to how Fathom Analytics or Google Analytics works in that when you provide a site ID/domain it then knows to include the code. It would provide for a more consistent user experience.

The enable field can now be dispensed with, and for services deployed using Plausible's official management, only the domain to be tracked need be provided.

Specifically, the event and script fields are retained, which is useful when users use self-hosted Plausible service or proxied Plausible API event and script.

@jpanther
Copy link
Owner

Thanks for the update. The only final change I would make is to rename the plausible config block to plausibleAnalytics. Again this is to maintain consistency with the existing googleAnalytics and fathomAnalytics parameters. Once this is done, I'm happy to merge this into the project.

@DejavuMoe
Copy link
Contributor Author

Thanks for the update. The only final change I would make is to rename the plausible config block to plausibleAnalytics. Again this is to maintain consistency with the existing googleAnalytics and fathomAnalytics parameters. Once this is done, I'm happy to merge this into the project.

Now it should be done.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity.
Please review the PR history and add a reply with any requested information. If no information has been requested, it may be that this contribution does not fit with the project objectives, or does not adhere to the contributing guidelines. If this is in error, please add a reply with further details.
This PR will automactically close in 14 days if no further activity occurs.

@github-actions github-actions bot added the stale This issue or pull request has not had any recent activity label Jul 27, 2023
@DejavuMoe
Copy link
Contributor Author

May this PR could be merged? @jpanther 🤔

@github-actions github-actions bot removed the stale This issue or pull request has not had any recent activity label Jul 28, 2023
@jpanther
Copy link
Owner

Thanks again @DejavuMoe. Sorry it's taken me a while to respond. I've been very busy with life challenges! I'm happy to merge this in and it will be included in the next release.

@jpanther jpanther merged commit f5da9f4 into jpanther:dev Aug 14, 2023
@DejavuMoe DejavuMoe deleted the patch-1 branch August 14, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants