Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test_utils.py not to xfail #987

Merged
merged 2 commits into from
Sep 28, 2024
Merged

fix test_utils.py not to xfail #987

merged 2 commits into from
Sep 28, 2024

Conversation

pachewise
Copy link
Contributor

See https://docs.pytest.org/en/stable/example/parametrize.html#parametrizing-conditional-raising. We should be "passing" the test if the correct action is to raise a ValueError.

auvipy
auvipy requested changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the patch. can you please check the test failures?

@pachewise
Copy link
Contributor Author

@auvipy the issue is the one we fixed in #986; once we merge that, the tests should pass here.
image

@auvipy auvipy merged commit a63d75c into jpadilla:master Sep 28, 2024
26 checks passed
@pachewise pachewise deleted the fix/test_utils branch October 6, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpadilla jpadilla jpadilla approved these changes

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pachewise @jpadilla @auvipy