Use constants for default values

Signed-off-by: Jo Vandeginste <[email protected]>
jovandeginste · Feb 22, 2024 · 44eb377 · 44eb377
1 parent 11f92b6
commit 44eb377
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/pkg/app/app.go b/pkg/app/app.go
@@ -21,6 +21,11 @@ import (
 	"github.com/vorlif/spreak/humanize/locale/nl"
 )
 
+const (
+	DefaultTheme    = "browser"
+	DefaultLanguage = "browser"
+)
+
 type Version struct {
 	BuildTime string
 	Ref       string

diff --git a/pkg/app/tempates.go b/pkg/app/tempates.go
@@ -61,7 +61,7 @@ func echoFunc(key string, _ ...interface{}) string {
 func (a *App) viewTemplateFunctions() template.FuncMap {
 	return template.FuncMap{
 		"i18n":               echoFunc,
-		"language":           func() string { return "browser" },
+		"language":           func() string { return DefaultLanguage },
 		"supportedLanguages": a.translator.SupportedLanguages,
 		"humanizer":          func() *humanize.Collection { return a.humanizer },
 

diff --git a/pkg/app/users_handlers.go b/pkg/app/users_handlers.go
@@ -68,8 +68,8 @@ func (a *App) userRegisterHandler(c echo.Context) error {
 		return a.redirectWithError(c, a.echo.Reverse("user-login"), fmt.Errorf("%w: %s", ErrInternalError, err))
 	}
 
-	u.Profile.Theme = "browser"
-	u.Profile.Language = "browser"
+	u.Profile.Theme = DefaultLanguage
+	u.Profile.Language = DefaultLanguage
 
 	if err := u.Create(a.db); err != nil {
 		return a.redirectWithError(c, a.echo.Reverse("user-login"), fmt.Errorf("%w: %s", ErrInternalError, err))