Fix ViewType caption type to not include react elements #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davwheat Updated based on our discussion in the Issue. |
davwheat
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Switches the
captiontype onViewTypefromReactNode, which includes all the renderable component and fragment types in react, to a subset of renderable primitives, which is what the downstream code actually can handle.Related issues (if any):
Fixes issue #367
Checks:
yarn run lintran successfully/srcand/examples/srcare committedyarn run lintdoesn't run successfully, but it also didn't run successfully before this commit. No new failures added.