fix: better error messages if graphql tried to run with csv only

joshstevens19 · Jul 14, 2024 · 6befb7d · 6befb7d
1 parent 6fb9591
commit 6befb7d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 15 deletions.
diff --git a/core/src/start.rs b/core/src/start.rs
@@ -85,21 +85,26 @@ pub async fn start_rindexer(details: StartDetails<'_>) -> Result<(), StartRindex
             }
 
             // Spawn a separate task for the GraphQL server if specified
-            let graphql_server_handle = if details.graphql_details.enabled {
-                let manifest_clone = Arc::clone(&manifest);
-                let indexer = manifest_clone.to_indexer();
-                let mut graphql_settings = manifest.graphql.clone().unwrap_or_default();
-                if let Some(override_port) = &details.graphql_details.override_port {
-                    graphql_settings.set_port(*override_port);
-                }
-                Some(tokio::spawn(async move {
-                    if let Err(e) = start_graphql_server(&indexer, &graphql_settings).await {
-                        error!("Failed to start GraphQL server: {:?}", e);
+            let graphql_server_handle =
+                if details.graphql_details.enabled && manifest.storage.postgres_enabled() {
+                    let manifest_clone = Arc::clone(&manifest);
+                    let indexer = manifest_clone.to_indexer();
+                    let mut graphql_settings = manifest.graphql.clone().unwrap_or_default();
+                    if let Some(override_port) = &details.graphql_details.override_port {
+                        graphql_settings.set_port(*override_port);
                     }
-                }))
-            } else {
-                None
-            };
+                    Some(tokio::spawn(async move {
+                        if let Err(e) = start_graphql_server(&indexer, &graphql_settings).await {
+                            error!("Failed to start GraphQL server: {:?}", e);
+                        }
+                    }))
+                } else {
+                    None
+                };
+
+            if graphql_server_handle.is_none() && details.graphql_details.enabled {
+                error!("GraphQL can not run without postgres storage enabled, you have tried to run GraphQL which will now be skipped.");
+            }
 
             if let Some(mut indexing_details) = details.indexing_details {
                 let postgres_enabled = &manifest.storage.postgres_enabled();

diff --git a/documentation/docs/pages/docs/start-building/running.mdx b/documentation/docs/pages/docs/start-building/running.mdx
@@ -10,7 +10,7 @@ You will need to make sure you have docker running on your machine before starti
 You can also run docker manually by using `docker compose up -d`.
 :::
 
-:::info
+:::warn
 graphql API can only be ran when you have a postgres storage setup in your YAML.
 :::