Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool args fix #466

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Pool args fix #466

merged 7 commits into from
Dec 12, 2023

Conversation

segasai
Copy link
Collaborator

@segasai segasai commented Dec 11, 2023

Address #464

Copy link
Contributor

@eteq eteq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a better fix for #464 !

One minor doc suggestion though, just to make sure the user catches that the concatenation behavior happens.

py/dynesty/pool.py Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 11, 2023

Pull Request Test Coverage Report for Build 7173093321

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 91.678%

Totals Coverage Status
Change from base Build 7105543502: -0.01%
Covered Lines: 4153
Relevant Lines: 4530

💛 - Coveralls

@segasai
Copy link
Collaborator Author

segasai commented Dec 11, 2023

Thanks for taking a look. I accepted your doc edit, but I didn't catch what you meant by this (or whether it was what exactly about your doc edit)

One minor doc suggestion though, just to make sure the user catches that the concatenation behavior happens.

I think the concatenation is mentioned now both in pool.py, and docs (and I don't think the runtime warning is needed here)

@segasai segasai merged commit 3f10025 into master Dec 12, 2023
6 checks passed
@segasai segasai deleted the pool_args_fix branch June 25, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants