-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pool args fix #466
Pool args fix #466
Conversation
now they can be specified both in the pool and sampler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as a better fix for #464 !
One minor doc suggestion though, just to make sure the user catches that the concatenation behavior happens.
Pull Request Test Coverage Report for Build 7173093321
💛 - Coveralls |
Co-authored-by: Erik Tollerud <[email protected]>
Thanks for taking a look. I accepted your doc edit, but I didn't catch what you meant by this (or whether it was what exactly about your doc edit)
I think the concatenation is mentioned now both in pool.py, and docs (and I don't think the runtime warning is needed here) |
Address #464