enc_counts_per_rev parameter changed to enc_counts_per_rev_l/r #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature that allows the user to configure a different cpr for each motor.
In this way, when the two motors have different cpr values and spin with different velocities for a closed-loop command with the same value for both motors (i.e. "m 50 50"), the user will be able to fix that and give each motor its corresponding cpr value.
This feature will also help to improve odom issues as, if motors have very different cpr but are set with the same cpr value, it will be impossible to get good odom measurements.