Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative url for notes.js #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

SWW13
Copy link

@SWW13 SWW13 commented May 8, 2019

The url for notes.js doesn't use the $reveal_location and therefor doesn't work for relative paths.

@joshed-io
Copy link
Owner

Thanks for the PR @SWW13. The notes plugin has an HTML file dependency that breaks CDN loading for some CDN's, hence why this is always pointed locally. But this isn't a great solution as it causes the problem you point out, so let me see if we can support both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants