Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct module folder name #18

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Direct module folder name #18

wants to merge 7 commits into from

Conversation

vbulash
Copy link

@vbulash vbulash commented May 6, 2023

Hello, Josh!

Rule "extract module folder name from module package name" seems not convenient.
Example:

  • I have 2 similar modules - Dashboard for App1 and Dashboard for App2. Names are identical, content - is not.
  • Yes, in GitHub / Packagist I have to put 2 repositories with exact names - vbulash/app1.dashboard-module and vbulash/app2.dashboard-module. Nothing against - I can't get identical repository names.
  • But after laravel-module-installer I see folders with names - Modules/App1.Dashboard and Modules\App2.Dashboard. Seems strange.
  • More flexible folder names - Modules\Dashboard for both cases.

I wrote few lines of code and some short text in readme to get this behavior (in addition to your way).

Hope it is good idea.

Regards,
Valery Bulash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant