Skip to content

Commit

Permalink
Improve tracing (#1318)
Browse files Browse the repository at this point in the history
* Add opentelemetry OTLP export support
* Rewrite top-level HTTP request handler - fix instrumentation
* Flush spans before shutdown
* Use OT "semantic conventions" for common fields

commit-id:4f45746e
  • Loading branch information
vlad-ivanov-name authored Mar 13, 2024
1 parent 2851e36 commit fa8a7e0
Show file tree
Hide file tree
Showing 4 changed files with 372 additions and 113 deletions.
220 changes: 218 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion josh-core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ pub fn get_change_id(commit: &git2::Commit, sha: git2::Oid) -> Change {
change
}

#[tracing::instrument(skip(transaction))]
#[tracing::instrument(level = tracing::Level::TRACE, skip(transaction))]
pub fn filter_commit(
transaction: &cache::Transaction,
filterobj: filter::Filter,
Expand Down
2 changes: 2 additions & 0 deletions josh-proxy/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,5 @@ tempdir = "0.3.7"
gix = { workspace = true }
juniper = { workspace = true }
git2 = { workspace = true }
opentelemetry-semantic-conventions = "0.14.0"
opentelemetry-otlp = "0.13.0"
Loading

0 comments on commit fa8a7e0

Please sign in to comment.