Recover properly serialized symbols

josfh2005 · Feb 23, 2021 · 9616e43 · 9616e43
1 parent 578e202
commit 9616e43
Show file tree

Hide file tree

Showing 3 changed files with 75 additions and 36 deletions.
diff --git a/src/dom_components/model/Component.js b/src/dom_components/model/Component.js
@@ -206,7 +206,7 @@ const Component = Backbone.Model.extend(Styleable).extend(
 
       if (!opt.temporary) {
         this.init();
-        this.__isSymbol() && this.__initSymb();
+        this.__isSymbolOrInst() && this.__initSymb();
         em && em.trigger('component:create', this);
       }
     },
@@ -619,9 +619,13 @@ const Component = Backbone.Model.extend(Styleable).extend(
       return isArray(this.get(keySymbols));
     },
 
+    __isSymbolOrInst() {
+      return !!(this.__isSymbol() || this.get(keySymbol));
+    },
+
     __isSymbolTop() {
       const parent = this.parent();
-      const symb = this.__isSymbol() || this.__getSymbol();
+      const symb = this.__isSymbolOrInst();
       return (
         symb &&
         (!parent || (parent && !parent.__isSymbol() && !parent.__getSymbol()))
@@ -666,7 +670,6 @@ const Component = Backbone.Model.extend(Styleable).extend(
       const { fromInstance } = opts;
       const symbols = this.__getSymbols() || [];
       const symbol = this.__getSymbol();
-      !symbols.filter && console.log('!symbols.filter', symbols);
       let result =
         symbol && !fromInstance
           ? [symbol]

diff --git a/src/dom_components/model/Components.js b/src/dom_components/model/Components.js
@@ -258,28 +258,30 @@ export default Backbone.Collection.extend({
   },
 
   __onAddEnd: debounce(function() {
-    const { domc } = this;
-    const allComp = (domc && domc.allById()) || {};
-    const firstAdd = this.__firstAdd;
-    const toCheck = isArray(firstAdd) ? firstAdd : [firstAdd];
-    const silent = { silent: true };
-    const onAll = comps => {
-      comps.forEach(comp => {
-        const symbol = comp.get(keySymbols);
-        const symbolOf = comp.get(keySymbol);
-        if (symbol && isArray(symbol) && isString(symbol[0])) {
-          comp.set(
-            keySymbols,
-            symbol.map(smb => allComp[smb]).filter(i => i),
-            silent
-          );
-        }
-        if (isString(symbolOf)) {
-          comp.set(keySymbol, allComp[symbolOf], silent);
-        }
-        onAll(comp.components());
-      });
-    };
-    onAll(toCheck);
+    // TODO to check symbols on load, probably this might be removed as symbols
+    // are always recovered from the model
+    // const { domc } = this;
+    // const allComp = (domc && domc.allById()) || {};
+    // const firstAdd = this.__firstAdd;
+    // const toCheck = isArray(firstAdd) ? firstAdd : [firstAdd];
+    // const silent = { silent: true };
+    // const onAll = comps => {
+    //   comps.forEach(comp => {
+    //     const symbol = comp.get(keySymbols);
+    //     const symbolOf = comp.get(keySymbol);
+    //     if (symbol && isArray(symbol) && isString(symbol[0])) {
+    //       comp.set(
+    //         keySymbols,
+    //         symbol.map(smb => allComp[smb]).filter(i => i),
+    //         silent
+    //       );
+    //     }
+    //     if (isString(symbolOf)) {
+    //       comp.set(keySymbol, allComp[symbolOf], silent);
+    //     }
+    //     onAll(comp.components());
+    //   });
+    // };
+    // onAll(toCheck);
   })
 });
diff --git a/test/specs/dom_components/model/Symbols.js b/test/specs/dom_components/model/Symbols.js
@@ -14,6 +14,10 @@ describe('Symbols', () => {
     comp.parent().append(cloned, { at: comp.index() + 1 });
     return cloned;
   };
+  const simpleCompDef = {
+    type: 'text',
+    components: [{ type: 'textnode', content: 'Component' }]
+  };
   const simpleComp = '<div data-a="b">Component</div>';
   const simpleComp2 = '<div data-b="c">Component 3</div>';
   const compMultipleNodes = `<div data-v="a">
@@ -26,6 +30,22 @@ describe('Symbols', () => {
   const getInnerComp = (cmp, i = 0) => cmp.components().at(i);
   const getFirstInnSymbol = cmp => getInnerComp(cmp).__getSymbol();
   const getInnSymbol = (cmp, i = 0) => getInnerComp(cmp, i).__getSymbol();
+  const basicSymbUpdate = (cFrom, cTo) => {
+    const rand = (Math.random() + 1).toString(36).slice(-7);
+    const newAttr = { class: `cls-${rand}`, [`myattr-${rand}`]: `val-${rand}` };
+    cFrom.setAttributes(newAttr);
+    cFrom.components(`New text content ${rand}`);
+    const toAttr = cTo.getAttributes();
+    delete toAttr.id;
+    const htmlOpts = {
+      attributes: (m, attr) => {
+        delete attr.id;
+        return attr;
+      }
+    };
+    expect(toAttr).toEqual(newAttr);
+    expect(cFrom.toHTML(htmlOpts)).toBe(cTo.toHTML(htmlOpts));
+  };
 
   beforeAll(() => {
     editor = new Editor({ symbols: 1 });
@@ -107,17 +127,31 @@ describe('Symbols', () => {
     comp.set(keySymbol, idSymb);
     symbol.set(keySymbols, [idComp]);
     // Check updates from instance
-    const newAttr = { class: 'test', myattr: 'myvalue' };
-    comp.setAttributes(newAttr);
-    comp.components('New text content');
-    expect(symbol.getAttributes()).toEqual(newAttr);
-    expect(symbol.toHTML()).toBe(comp.toHTML());
+    basicSymbUpdate(comp, symbol);
     // Check updates from symbol
-    const newAttr2 = { class: 'test2', myattr2: 'myvalue2' };
-    symbol.setAttributes(newAttr2);
-    symbol.components('New text content2');
-    expect(comp.getAttributes()).toEqual(newAttr2);
-    expect(symbol.toHTML()).toBe(comp.toHTML());
+    basicSymbUpdate(symbol, comp);
+  });
+
+  test('Symbols recovers correctly from serialization', () => {
+    const idComp = 'c1';
+    const idSymb = 's1';
+    const defComp = {
+      ...simpleCompDef,
+      [keySymbol]: idSymb,
+      attributes: { id: idComp }
+    };
+    const defSymb = {
+      ...simpleCompDef,
+      [keySymbols]: [idComp],
+      attributes: { id: idSymb }
+    };
+    const [comp, symbol] = wrapper.append([defComp, defSymb]);
+    expect(comp.__getSymbol()).toBe(symbol);
+    expect(comp.get(keySymbol)).toBe(symbol);
+    expect(symbol.__getSymbols()[0]).toBe(comp);
+    expect(symbol.get(keySymbols)[0]).toBe(comp);
+    basicSymbUpdate(comp, symbol);
+    basicSymbUpdate(symbol, comp);
   });
 
   test("Removing one instance doesn't affect others", () => {