Code reorganization to facilitate planned Added/Changed extensions
#29
Conversation
bzm3r
changed the title
Added/Changed extension`Added/Changed extensions
|
@JoJoJet ah, What I can do is keep this PR open, and work on the added/changed stuff. Once that PR is up, you'll have more information as to how things ought to be organized? |
|
Okay, because it seemed that I can keep the But can have you a look at how multiple_read and multiple_write change here, and then decide whether they should still be collapsed: #30 |
|
I will leave the decision up to you, but IMO it's fine to just merge those files. |
| //! Trait queries support basic change detection filtration. So to get all the components that | ||
| //! implement the target trait, and have also changed in some way since the last tick, you can: | ||
| //! ```ignore | ||
| //! fn show_tooltips( | ||
| //! tooltips: Query<ChangedAll<&dyn Tooltip>> | ||
| //! // ... | ||
| //! ) { | ||
| //! for tooltip in &tooltips { | ||
| //! println!("changed tool tips: {}", tooltip.tooltip()); | ||
| //! } | ||
| //! } | ||
| //! ``` | ||
| //! | ||
| //! Similarly, there exist `ChangedOne`, `AddedOne`, and `AddedAll`. | ||
| //! |
There was a problem hiding this comment.
I don't think this belongs here?
Co-authored-by: JoJoJet <[email protected]>
|
So, apparently cargo-rdme doesn't like re-exports, so that doc link on line 167 of lib.rs needs to be |
|
Github won't let me push to this branch, so I'm just going to go ahead and merge this, then apply my nitpicks in a follow-up PR. |
Fixes some nitpicks introduced by #29.
lib.rsis becoming quite unwieldy with the new extensions planned toAdded/Changed: for instance, there will be newWorldQueryadapters,ReadTraitsiterators, and newWriteTraitsiterators. In order to make the file easier to navigate, and thereby mitigate the risk of errors, I think it will be useful to reorganize the code