Proposal to use method options cloning #354
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies a proposed pattern to handle a problem with request options mutation performed by client operations.
Problem details
new ChatClient(modelName).CompleteChat(messages, options)
"promotes" themodelName
andmessages
parts out of theoptions
max_completion_tokens
workaroundLonger term approaches
Interim approach
Object.MemberwiseClone()
to form a shallow copy, coupled with a shallow copy of the additional binary data properties dictionary (so the operation can update the dictionary)internal virtual TOptions CreatePerCallOptions(TOptions originalOptions, ...)
that usesGetClone()
and then performs the needed reconstitution (like emplacingmodel
andmessages
for Chat Completions) on the clone, never modifying the originalAzureChatClient
) can override theCreatePerCallOptions
to efficiency supplement treatment of the clone without needing to manage "clones of clones" or similar