Experiment #312
Draft
Experiment #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M-provided two-way subclient
annelo-msft
commented
Oct 28, 2024
.dotnet/api/OpenAI.netstandard2.0.cs
Outdated
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public virtual Task SendCommandAsync(BinaryData data, RequestOptions options); | ||
| public Task StartResponseTurnAsync(CancellationToken cancellationToken = default); | ||
| public virtual AssistantConversation StartConversation(ConversationSessionOptions options, CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
Should take AssistantConversationOptions
annelo-msft
commented
Oct 28, 2024
| public virtual AssistantConversation StartConversation(BinaryContent configuration, TwoWayClient.TwoWayPipelineOptions conversationOptions, RequestOptions requestOptions); | ||
| public AssistantConversation StartConversation(CancellationToken cancellationToken = default); | ||
| public virtual Task<AssistantConversation> StartConversationAsync(AssistantConversationOptions options, CancellationToken cancellationToken = default); | ||
| public virtual Task<AssistantConversation> StartConversationAsync(BinaryContent configuration, TwoWayClient.TwoWayPipelineOptions conversationOptions, RequestOptions requestOptions); |
There was a problem hiding this comment.
What does it look like to configure the conversation in a protocol-only world? (When we have munged HTTP and WebSocket messages -- i.e. making two calls on different protocols from the Start method?)
annelo-msft
commented
Nov 18, 2024
|
|
||
| List<ConversationUpdate> receivedUpdates = []; | ||
| IAsyncEnumerable<TwoWayResult<ConversationResponse>> responseStream = conversation.GetResponseStreamAsync(CancellationToken); |
There was a problem hiding this comment.
Get message stream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based in WIP SCM build here: Azure/azure-sdk-for-net#46737