Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system fixes / improvements #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Build system fixes / improvements #33

wants to merge 4 commits into from

Conversation

nebw
Copy link

@nebw nebw commented Sep 26, 2015

I wasn't able to build cgt on my system, so I had to make a couple of modifications to the CMake script:

  • I already have OpenBLAS installed. I such a case, cgt should not download and compile OpenBLAS. I added FindOpenBLAS.cmake from the caffe repository and modified the CMake script so that OpenBLAS is only built from scratch if FindOpenBLAS.cmake can't find OpenBLAS on the system
  • appending to CMAKE_C_FLAGS/CMAKE_CXX_FLAGS broke the build on my system because it adds a ';' before appending the string. According to the CMake docs, APPEND is meant for lists (not strings), which are sepearted by semicolons in CMake.

@nebw nebw mentioned this pull request Sep 26, 2015
Closed
f0k
f0k reviewed Sep 28, 2015
View reviewed changes
CMakeLists.txt
else()
list( APPEND CMAKE_CXX_FLAGS "-std=c++11")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nebw @f0k