This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
Implements refresh token behaviour #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcarrolle nice, however storing and reading from the cache is not the best idea unfortunately, it already causes a lot of problems in the connection/link process and that is only a few minutes. Can we think of a different way of storing it? |
|
Yes you are right. Refresh token need to be stored in reliable storage like database. I am going to add two method (getRefreshToken and saveRefreshToken) in the UserService interface. Is it OK for you ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improvements relates to this issue #57
I create a method refresh which contains the logic to perform a refresh token action. I implement only for GoogleAuthProvider. I modify PlayAuthenticate.isLoggedIn method to launch the refresh token action when the current token is expired.