refactor(selection-tools): remove redundant getPreferredLanguage ca…

…lls (#593)
josStorer · Dec 21, 2023 · 2e8911d · 2e8911d
1 parent 8230f5f
commit 2e8911d
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/content-script/selection-tools/index.mjs b/src/content-script/selection-tools/index.mjs
@@ -20,7 +20,12 @@ const createGenPrompt =
     includeLanguagePrefix = false,
   }) =>
   async (selection) => {
-    const preferredLanguage = isTranslation ? targetLanguage : await getPreferredLanguage()
+    let preferredLanguage = targetLanguage
+
+    if (!preferredLanguage) {
+      preferredLanguage = await getPreferredLanguage()
+    }
+
     let fullMessage = isTranslation
       ? `Translate the following into ${preferredLanguage} and only show me the translated content`
       : message
@@ -45,7 +50,6 @@ export const config = {
     label: 'Translate',
     genPrompt: createGenPrompt({
       isTranslation: true,
-      targetLanguage: await getPreferredLanguage(),
     }),
   },
   translateToEn: {
@@ -69,7 +73,6 @@ export const config = {
     label: 'Translate (Bidirectional)',
     genPrompt: createGenPrompt({
       isTranslation: true,
-      targetLanguage: await getPreferredLanguage(),
       enableBidirectional: true,
     }),
   },