Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Issue 125 #128

Merged
merged 2 commits into from
Apr 23, 2024
Merged

[Fix] Issue 125 #128

merged 2 commits into from
Apr 23, 2024

Conversation

dtroupe-plaid
Copy link
Contributor

@dtroupe-plaid dtroupe-plaid commented Apr 23, 2024 •
edited
Loading

This PR resolves issue 125. It's similar to the latest changes made to the React Native SDK.

The root cause of this issue is that HANDOFF isn't sent until after onSuccess since the hander is being deallocated in the successHandler the eventHander never receives the final HANDOFF event.

This PR:

  1. Deallocates the hander for OnExit because there won't be a HANDOFF event.
  2. Stop deallocating the hander for onSuccess.
  3. Deallocates the handler once the HANDOFF event is received.

@dtroupe-plaid dtroupe-plaid mentioned this pull request Apr 23, 2024
Closed
@jorgefspereira jorgefspereira merged commit 4cbfb1a into jorgefspereira:master Apr 23, 2024
@dtroupe-plaid dtroupe-plaid deleted the fix-handoff-issue branch June 20, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not receiving HANDOFF events when linking an account
2 participants
@dtroupe-plaid @jorgefspereira