Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Elements #758

Closed
wants to merge 1 commit into from
Closed

Conversation

frenzzy
Copy link
Contributor

@frenzzy frenzzy commented Sep 13, 2018

Custom elements usually control their children nodes themselves and hyperapp should not touch them during hydration and lifecycle.

Fixes #757

@jorgebucaran
Copy link
Owner

Thank you, @frenzzy. It looks hacky, won't you agree? How infallible do you think this is? 😄

@frenzzy
Copy link
Contributor Author

frenzzy commented Sep 13, 2018

Oh, exceptions...

name must not be any of the following:

  • annotation-xml
  • color-profile
  • font-face
  • font-face-src
  • font-face-uri
  • font-face-format
  • font-face-name
  • missing-glyph

@zaceno
Copy link
Contributor

zaceno commented Sep 13, 2018

I don't think we want this. Sure custom-elements control their children, but this takes away our ability to compose with custom elements. Like what if I had a custom element that displays whatever in a modal:

...
<custom-modal titleBarText="Blah">
  <Foo state={state.foo} />
  <p>{state.bar}</p>
</custom-modal>
...

We still want ability to use custom elements meant to work like that, right?

@frenzzy
Copy link
Contributor Author

frenzzy commented Sep 13, 2018

Yes, you are right! Closing here.

@frenzzy frenzzy closed this Sep 13, 2018
@jorgebucaran jorgebucaran added the invalid This doesn't seem right label Sep 14, 2018
Repository owner locked and limited conversation to collaborators Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants