Deterministic page headers by exploring pages via rootPage.pages key #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This helps me to read code more easily by making assumptions about the current type and then change the assumption if I ever encounter a different type of the same function/variables - All types added in comments thus optional Paradoc developers/users don't have to install any tools to develop/use Paradoc - To make use of Typescript's type intellisense you can open Paradoc.js in any editor that support Typescript's Language Server Protocol (for example: VSCode, Oni2)
- Adds a new method for exploring all pages via new header in rootPage.pages (as comma separated string, due to limitation of current YAML parser) - The order specified in rootPage.pages will be used for rendering sticky page headers. - Page specific headers like hideInNav/ hideInSearch are respected
|
Sorry for force pushing. I messed up with conflicts resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here #2 (comment)
This PR adds a new method for exploring all pages via new header in
rootPage.pages. (as comma separated string, due to limitation of current YAML parser). The order specified inrootPage.pageswill be used for rendering Sticky page headers. Page specific headers likehideInNav/hideInSearchare respected and aren't overrided.There are 2 commits in this PR, the first one is for adding Typescript via JSDoc comments, you should skip it and look at the second commit here.