Drop using {open,close}pixel() in favor of setting input shape to a 0x0 rect #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the input shape to be empty so that one cannot click on the grid. This resolves all issues where the cursor ends up pointing to the grid itself instead of the window under the grid due to openpixel() not being called.
Input shape is now set to 0x0, which takes care of the functionality
that {open,close}pixel() previously provided. As such, completely remove
{open,close}pixel() since they're no longer needed. In addition, remove
the mouseinfo var and the mouseinfo_t type since those were used only by
{open,close}pixel().
ashish-yadav11
added a commit
to ashish-yadav11/keynav
that referenced
this pull request
Oct 18, 2021
Part of the X Nonrectangular Window Shape Extension includes the ability
to set the input shape. Setting the input shape to what is effectively a
0x0 rectangle results in a grid that cannot be clicked on; clicks and
motion events end up being passed to the window below the grid.
Since this basically achieves what {open,close}pixel() was originally
made for, we can just set the input shape as part of the initialization
for our window and remove {open,close}pixel() and mouseinfo, as they are
no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the X Nonrectangular Window Shape Extension includes the ability to set the input shape. Setting the input shape to what is effectively a 0x0 rectangle results in a grid that cannot be clicked on; clicks and motion events end up being passed to the window below the grid.
Since this basically achieves what {open,close}pixel() was originally made for, we can just set the input shape as part of the initialization for our window and remove {open,close}pixel() and mouseinfo, as they are no longer needed.