[5.2] Fix for: Article cannot be saved successfully on the front-end

[NicolasDerumigny]

Pull Request for Issue #37106 (or, at least, an issue having the exact same symptoms and behaviour).

Summary of Changes

Modify the element used for button data selector when using any button of the com_content edit form on the front-end.

Testing Instructions

Modify an existing article using the front-end. Save by clicking specifically on the checkbox icon in the save button (so that the event.target is the span.icon-check).

Actual result BEFORE applying this Pull Request

The article is not saved, as the POST request sent to the server has an empty task field.

Expected result AFTER applying this Pull Request

The article is correctly saved.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[fgsw]

@NicolasDerumigny Can you change the title of the Pull Request to something more meaningful cause the title will be used in the changelog.

Maybe something like "[5.2] Fix for: Article cannot be saved successfully".

[NicolasDerumigny]

Of course. That's done!

[fgsw]

Save by clicking specifically on the checkbox icon in the save button (so that the event.target is the span.icon-check).

Can you provide a screenshot where to click or explain in another way?

[NicolasDerumigny]

Of course. JavaScript set in event.target the element that is clicked, which may be a child of the element containing the handler (detailed explanation here: https://fr.javascript.info/bubbling-and-capturing). In my case, the save buttons are like this:

Which translate in the HTML syntax to (for a single button):

<button type="button" class="btn btn-primary" data-submit-task="article.apply">
   <span class="icon-check" aria-hidden="true"></span>
   Enregistrer 
</button>

Therefore, clicking on the "check" icon (corresponding to the span tag) triggers the save event with the span as event.target, which is used to determine the task using the data-submit-task property. As the span does not have it (only the button does), an empty string is transmitted in the POST request in the task variable and the bug occurs.

[fgsw]

Thanks but can you provide a screenshot where to click to get the bug?

[NicolasDerumigny]

Of course, it's on the blue section here (in the front-end only):

[fgsw]

I have tested this item ✅ successfully on 8e6ae5c

Test by using default 5.2.2 + prebuilt update package.

@NicolasDerumigny I haven't noticed its about the frontend. Can you update the test instructions like "Modify an existing article in the frontend."?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44680.}

[NicolasDerumigny]

That's done! Let me know if you need anything else!

[C-Lodder]

Note, you can also use e.currentTarget

[chmst]

I have tested this item ✅ successfully on 8e6ae5c

Before patch: Click on the icon itself: article is not saved. No warning no error.

After Patch: Article is saved with "success" message, as expected.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44680.}

[fgsw]

Can the PR get synced with the base branch and set as "Ready To Commit"?

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44680.}

[alikon]

Can the PR get synced with the base branch

a task for Mantainers / Release Manager

[fgsw]

a task for Mantainers / Release Manager

@alikon Thanks for info. I thought it has to be the other way round.

[NicolasDerumigny]

I can do it, if this means "rebase to current 5.2-dev top"

[alikon]

oh yes, forgot to mention that the pr author can do it
@NicolasDerumigny if you do it i'll restore the RTC status

[NicolasDerumigny]

There you go :)

[QuyTon]

Why not change it as suggested here? #44680 (comment)

[NicolasDerumigny]

In this case, both are strictly equivalent. I changed it that way to avoid confusion between currentTarget and target, and it is more natural for me to use button which is a constant in the context of the event function rather that the variable e, but this is clearly up to personal taste.

[Hackwar]

Thank you very much! Awesome find!