-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Remove deprecate strings in Com_admin #40467
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [4.3] Single line comment Codestyle fix (spotted while doing something else - might as well fix it) * Update default.php
Simple PR to correct some comments and copyright date from @wilsonge joomla#36499
When adding a link to a docblock it should use `@link` according to the specifications and not `@see` which is for internal use. Reference https://manual.phpdoc.org/HTMLSmartyConverter/PHP/phpDocumentor/tutorial_tags.link.pkg.html https://manual.phpdoc.org/HTMLSmartyConverter/PHP/phpDocumentor/tutorial_tags.see.pkg.html
currently they are hard coded to be displayed by id desc this pr will (when finished) allows the order to be set using drag and drop from com_menus&view=menus This is for the display of the menus in the sidebar and the menus dashboard --------- Co-authored-by: Harald Leithner <[email protected]> Co-authored-by: Quy <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
…ive button - the button may cause a page redirect or form submission (joomla#41155)
…tive tour before attempting to focus on the tour buttons! (joomla#41160)
* Document event: BeforeCompileHeadEvent * Document event: AfterInitialiseDocumentEvent * Document event, phpcs * Document event, revert classes * Document event, cleanup * Document event, AfterInitialiseDocument Event
* App events: create * App events: base app event * App events: add couple event classes * App events: doc event * App events: organize * App events, couple more events * App events, formatting * App events, more events * App events, doc to app * App events, use same dispatcher * App events, create to new --------- Co-authored-by: Harald Leithner <[email protected]>
Upmerge 20230721 from 4.3-dev
Upmerge20230721 latest PR's from 4.3
…omla#41202) * Move classmap import to the plugin constructor * Move es5 assets to b/c plugin --------- Co-authored-by: Brian Teeman <[email protected]>
* added a test for contact group field * updates ---------
* added an api test for content group fields * changing file location ---------
* updnft2task * better name * Update administrator/components/com_admin/script.php Co-authored-by: Richard Fath <[email protected]> * Update administrator/components/com_admin/script.php Co-authored-by: Richard Fath <[email protected]> * cache_timeout * lastrun * cs * Update administrator/components/com_admin/script.php Co-authored-by: Richard Fath <[email protected]> * Update installation/sql/mysql/base.sql Co-authored-by: Richard Fath <[email protected]> * Update installation/sql/postgresql/base.sql Co-authored-by: Richard Fath <[email protected]> * Update administrator/components/com_admin/script.php Co-authored-by: Richard Fath <[email protected]> * Update administrator/components/com_admin/script.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/updatenotification/src/Extension/UpdateNotification.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/updatenotification/src/Extension/UpdateNotification.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/updatenotification/src/Extension/UpdateNotification.php Co-authored-by: Richard Fath <[email protected]> * delete system plugin * settingson install * bettersyntax * hardcode-nestedset * hardcode-nestedset * grr * hardcode-nestedset * hardcode-nestedset * prefix * fix pgsql * Rename 5.0.0-2023-06-18.sql to 5.0.0-2023-08-04.sql shift * Rename 5.0.0-2023-06-18.sql to 5.0.0-2023-08-04.sql shift * Update administrator/language/en-GB/plg_task_updatenotification.ini Co-authored-by: heelc29 <[email protected]> * Update administrator/components/com_admin/script.php Co-authored-by: heelc29 <[email protected]> * Update administrator/language/en-GB/plg_task_updatenotification.ini Co-authored-by: heelc29 <[email protected]> * Update plugins/task/updatenotification/services/provider.php Co-authored-by: heelc29 <[email protected]> * Update plugins/task/updatenotification/forms/sendForm.xml Co-authored-by: heelc29 <[email protected]> * Update administrator/language/en-GB/plg_task_updatenotification.ini Co-authored-by: heelc29 <[email protected]> * remove old language files * add mail template for new installations * remove postinstall message * alphasort * upper case see line 203 * class Text not imported * feedback from session gc * remove old mail template on update * set created_by for new task * cs * exec-day * Update administrator/components/com_admin/script.php Co-authored-by: Richard Fath <[email protected]> * Rename 5.0.0-2023-08-04.sql to 5.0.0-2023-08-24.sql * Rename 5.0.0-2023-08-04.sql to 5.0.0-2023-08-24.sql * Rename 5.0.0-2023-08-24.sql to 5.0.0-2023-08-30.sql * Rename 5.0.0-2023-08-24.sql to 5.0.0-2023-08-30.sql * SQL CS * SQL CS * Fix plugin name in email body * Single quotes Co-authored-by: heelc29 <[email protected]> * Revert text function for plugins * Remove extra reference assignment for dispatcher argument Co-authored-by: heelc29 <[email protected]> * Set last and next execution and locked of task on new installation * SQL CS * Task should be enabled on a new installation * Make sure to have UTC timestamps on PostgreSQL * Rename 5.0.0-2023-08-30.sql to 5.0.0-2023-09-02.sql * Rename 5.0.0-2023-08-30.sql to 5.0.0-2023-09-02.sql * Fix lastrun default on update * Add parameters to SQL insert of task --------- Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: heelc29 <[email protected]>
* add2scheduler-logsdelete-logsrotate * cs * Update administrator/language/en-GB/plg_task_deletelogs.ini Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_task_deletelogs.sys.ini Co-authored-by: Brian Teeman <[email protected]> * Update plugins/task/deletelogs/services/provider.php Co-authored-by: Brian Teeman <[email protected]> * Update plugins/task/deletelogs/services/provider.php Co-authored-by: Brian Teeman <[email protected]> * Update plugins/task/deletelogs/src/Extension/DeleteLogs.php Co-authored-by: Brian Teeman <[email protected]> * Update plugins/task/deletelogs/src/Extension/DeleteLogs.php Co-authored-by: Brian Teeman <[email protected]> * Update plugins/task/deletelogs/src/Extension/DeleteLogs.php Co-authored-by: Brian Teeman <[email protected]> * Update plugins/task/deletelogs/src/Extension/DeleteLogs.php Co-authored-by: Brian Teeman <[email protected]> * Update plugins/task/deletelogs/src/Extension/DeleteLogs.php Co-authored-by: Brian Teeman <[email protected]> * Update plugins/task/deletelogs/deletelogs.xml Co-authored-by: jsanders <[email protected]> * Update plugins/task/deletelogs/src/Extension/DeleteLogs.php Co-authored-by: jsanders <[email protected]> * unsed * alpha order * Update plugins/task/deletelogs/src/Extension/DeleteLogs.php Co-authored-by: jsanders <[email protected]> * Update plugins/task/deletelogs/deletelogs.xml Co-authored-by: Harald Leithner <[email protected]> * renamed * remove from actionlogs * 2task * rename task as deleteactionlog * migrateLogRotationPlugin * actionlogmigr * unused * fixconflict1 * fixedconflicts * Update administrator/components/com_admin/script.php Co-authored-by: Richard Fath <[email protected]> * Update administrator/components/com_admin/script.php Co-authored-by: Richard Fath <[email protected]> * split deleteactionlogs * fixconflics1 * fixconflicts2 * Fix PHPCS * Fix PHPCS * hardcode-nestedset * 30d * Rename 5.0.0-2023-06-12.sql to 5.0.0-2023-08-01.sql shift * Rename 5.0.0-2023-06-12.sql to 5.0.0-2023-08-01.sql shift * Update installation/sql/mysql/base.sql Co-authored-by: Richard Fath <[email protected]> * Update installation/sql/postgresql/base.sql Co-authored-by: Richard Fath <[email protected]> * Update administrator/components/com_admin/script.php Co-authored-by: Richard Fath <[email protected]> * norma * Update administrator/language/en-GB/plg_task_rotatelogs.sys.ini Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_task_rotatelogs.ini Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_task_rotatelogs.ini Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_task_rotatelogs.ini Co-authored-by: Brian Teeman <[email protected]> * Rename 5.0.0-2023-08-01.sql to 5.0.0-2023-08-22.sql * Rename 5.0.0-2023-08-01.sql to 5.0.0-2023-08-22.sql * old lang string * Update administrator/components/com_admin/script.php * Update administrator/components/com_admin/script.php * Rename 5.0.0-2023-08-22.sql to 5.0.0-2023-08-29.sql * Rename 5.0.0-2023-08-22.sql to 5.0.0-2023-08-29.sql * Rename 5.0.0-2023-08-29.sql to 5.0.0-2023-08-30.sql * Rename 5.0.0-2023-08-29.sql to 5.0.0-2023-08-30.sql * Fix PHPCS * Delete old system plugin langage files * SQL CS * SQL CS * Fix nextval for asset ID sequence * Single quotes * Remove extra reference assignment for dispatcher argument * Check for disable plugin first * Use 30 days default value * SQL CS * Set last and next execution and locked of task on new installation * SQL CS * Task should be enabled on a new installation * Make sure to have UTC timestamps on PostgreSQL * Rename 5.0.0-2023-08-30.sql to 5.0.0-2023-09-02.sql * Rename 5.0.0-2023-08-30.sql to 5.0.0-2023-09-02.sql * Add parameters to SQL insert of task * Fix logstokeep default value on update * Fix lastrun default on update * SQL fixes due to previous conflict resolution --------- Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: jsanders <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Harald Leithner <[email protected]> Co-authored-by: Richard Fath <[email protected]>
* Editor Article XTD button use postMessage() * Module XTD button use postMessage() * Fields XTD button use postMessage()
* Commit current status * Some dark mode upgrades * Fix more white things * Dropdown support * Normalise * Fix RTL Background * Playing around with more things * Fix code style * Remove color overrides for now and remove white offset on list groups * More cpanel tweaks * Fix choices * Fix body bg * CS * Toolbar and quickicon improvements * Improve tabs * Various dropdown fixes * Fix legend * Toolbar button improvements * Codestyle and media manager first pass * Background of drag/drop area * Move variables across to the dark vars file
* 2task * Update plugins/task/privacyconsent/privacyconsent.xml Co-authored-by: jsanders <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/privacyconsent.xml Co-authored-by: jsanders <[email protected]> * remove plg_system_privacyconsents * Update base.sql * Update base.sql * re-add system privacyconsent * consentexpirationdays * re-add system privacyconsent * move 2 task * update & core plugin * nomore expiration fieldset * redesign * mail * mail_templates * Update libraries/src/Extension/ExtensionHelper.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * Update plugins/task/privacyconsent/src/Extension/PrivacyConsent.php Co-authored-by: Richard Fath <[email protected]> * migratePrivacyconsentConfiguration * PrivacyConsent migr * Rename 5.0.0-2023-06-13.sql to 5.0.0-2023-08-03.sql shift * Rename 5.0.0-2023-03-13.sql to 5.0.0-2023-08-03.sql shift * Rename 5.0.0-2023-08-03.sql to 5.0.0-2023-08-23.sql * Rename 5.0.0-2023-08-03.sql to 5.0.0-2023-08-23.sql * userfactory * userfactory * delete mail_template * delete mail_template * Rename 5.0.0-2023-08-23.sql to 5.0.0-2023-08-30.sql * Rename 5.0.0-2023-08-23.sql to 5.0.0-2023-08-30.sql * Deprecate language strings * One more deprecated language string * Do not add task when consent expiration was disabled * Use Registry when using get method later. * My mistake from previous commit * Add missing use statement for my previos commits * Cachetimeout was given in days in the system plugin, and default was 30. * Don't migrate if the system plugin was not found * Single quotes * Remove extra reference assignment for dispatcher argument * Rename 5.0.0-2023-08-30.sql to 5.0.0-2023-09-02.sql * Rename 5.0.0-2023-08-30.sql to 5.0.0-2023-09-02.sql * Fix lastrun default on update * Fix previous conflict resolution * Forgotten fix * Use the right language strings in the form * Fix update SQL scripts missing column value --------- Co-authored-by: jsanders <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Richard Fath <[email protected]>
* Fix undefined variables in scss * Fix undefined variables in scss
* add2schedulerdeleteactionlogs * cs * Rename 5.0.0-2023-06-27.sql to 5.0.0-2023-08-05.sql shift * Rename 5.0.0-2023-06-27.sql to 5.0.0-2023-08-05.sql shift * Rename 5.0.0-2023-08-05.sql to 5.0.0-2023-08-25.sql * Rename 5.0.0-2023-08-05.sql to 5.0.0-2023-08-25.sql * Update plugins/task/deleteactionlogs/src/Extension/DeleteActionLogs.php Co-authored-by: heelc29 <[email protected]> * blank-line * blank-line * blank-line * remove config node * Rename 5.0.0-2023-08-25.sql to 5.0.0-2023-08-30.sql * Rename 5.0.0-2023-08-25.sql to 5.0.0-2023-08-30.sql * Deprecate language strings * Single quotes * Remove extra reference assignment for dispatcher argument * Do it in the same way as in PR joomla#40553 * Rename 5.0.0-2023-08-30.sql to 5.0.0-2023-09-02.sql * Rename 5.0.0-2023-08-30.sql to 5.0.0-2023-09-02.sql * Fix lastrun default on update * CS * deploy version * Do nothing if params is an empty JSON * Fix migration methods and comment typos * Use the right task type * Fix undefined array element "exec-day" --------- Co-authored-by: Richard Fath <[email protected]> Co-authored-by: heelc29 <[email protected]> Co-authored-by: Richard Fath <[email protected]>
bump to a new version so that we have the latest with beta1
@brianteeman Can you please update this PR? |
brianteeman
requested review from
laoneo,
HLeithner,
chmst,
bembelimen,
zero-24,
rdeutz,
Hackwar,
fancyFranci and
wilsonge
as code owners
September 3, 2023 21:28
joomla-cms-bot
added
Unit/System Tests
and removed
Language Change
This is for Translators
labels
Sep 3, 2023
made a new pr instead #41576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused strings marked as deprecated with #40466