-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Standard Fields index #356
base: main
Are you sure you want to change the base?
Conversation
Added a section that lists optional options for all field types
Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here. PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here. PR Code Suggestions ✨Explore these optional code suggestions:
|
Looks nice, but I miss the data and aria attributes? or are they already documented somewhere? |
Good Point - I've missed that - data attributes are ok - but when testing aria as form field attribute (backend module params for example) it does not get rendered there... |
Added data- Attribute as option including information where it will be added and an example.
Hmm, ai have to look at the but thought it should be exposed... |
It's important to be clear about the difference between 2 different things:
Most of what you have are attributes, and for these I think that it would be better to include those in the Standard Form Field Attributes page at https://manual.joomla.org/docs/general-concepts/forms-fields/standard-form-field-attributes/ . You can always link to that from the index page, if you think that's appropriate. There's a bit of overlap in that the "pattern" and "class" are in both your list and on that Standard Form Field Attributes page. Also the "validate" attribute is still used by Joomla - for server-side validation. It's on that page as well. However, some of your items are just elements in the I've often thought it poor that these |
thanks @robbiejackson I missed https://manual.joomla.org/docs/next/general-concepts/forms-fields/standard-form-field-attributes/ I have the feeling that "Form" and "Fields" needs a better structure, not sure in which direction but at least mennu ordering might be needed. I would also suggest to structure the standard attributes and similar in away that we automatically include them in each fields for better DX. I created a test PR at #357 |
@robbiejackson oooh I've missed that too... but as @HLeithner mentioned if we don't see it we need to change something in the structure. |
User description
Added a section that lists optional options for all field types
PR Type
Documentation
Description
FormField
classChanges walkthrough 📝
index.md
Documentation of Common Form Field Options
docs/general-concepts/forms-fields/standard-fields/index.md
field types
disabled, etc.
client-side validation