Code

Refactoring IpHelper#33

Code

Open

nibra wants to merge 24 commits intojoomla-framework:1.x-devjoomla-framework/utilities:1.x-devfrom nibra:refactoring/ip-helpernibra/utilities:refactoring/ip-helperCopy head branch name to clipboard

+1,433-796

Commits

Commits on Mar 29, 2021

• Refactor ArrayHelperTest

  nibra

  committed
  663fdbb

  Copy full SHA for 663fdbb

Commits on Mar 30, 2021

• Feature - Add RegEx utility

  Show description for d2d2771
  nibra

  committed
  d2d2771

  Copy full SHA for d2d2771

• Style - Fix codestyle issues

  nibra

  committed
  66f8083

  Copy full SHA for 66f8083

• Tests - Remove call to expectedException (not supported in old PHPUnit versions)

  nibra

  committed
  9eb007b

  Copy full SHA for 9eb007b

• Compatibility - Add manual implementation for array_filter for PHP <5.6

  nibra

  committed
  9d21dd0

  Copy full SHA for 9d21dd0

• Compatibility - PHP 5.3 seems to be unable to deal with static closures

  nibra

  committed
  7ad3512

  Copy full SHA for 7ad3512

• Style - Closing parenthesis of a multi-line function call must be on a line by itself

  nibra

  committed
  b85cacc

  Copy full SHA for b85cacc

• Style - Multi-line function call not indented correctly

  nibra

  committed
  805defa

  Copy full SHA for 805defa

• Build - Remove PHPUnit patch

  nibra

  committed
  b0b9556

  Copy full SHA for b0b9556

Commits on Mar 31, 2021

• Tests - Add tests for IpHelper

  nibra

  committed
  88e3d56

  Copy full SHA for 88e3d56

Commits on Apr 1, 2021

• Tests - Add test cases for partial invalid network range

  nibra

  committed
  78d9c53

  Copy full SHA for 78d9c53

• Tests - Remove code coverage directive

  nibra

  committed
  a53173f

  Copy full SHA for a53173f

• Refactoring - Deprecate IP cache, which made IpHelper a Singleton

  nibra

  committed
  0c9b91d

  Copy full SHA for 0c9b91d

• Refactoring - Deprecate global allowOverride, which made IpHelper a Singleton

  nibra

  committed
  bbd587f

  Copy full SHA for bbd587f

• Refactoring - Remove check for existence of inet_ntop and/or inet_pton - they are always present since PHP 5.1

  nibra

  committed
  87e0b9e

  Copy full SHA for 87e0b9e

• Refactoring - Remove check for existence of getenv - it is always present since PHP 4

  nibra

  committed
  2e0ad6e

  Copy full SHA for 2e0ad6e

• Refactoring - Use strpos instead of strstr (saves memory), use strict comparision

  nibra

  committed
  fe93af7

  Copy full SHA for fe93af7

• Refactoring - Simplify and harden IP detection

  nibra

  committed
  55f49b1

  Copy full SHA for 55f49b1

• Refactoring - Complete refactoring

  nibra

  committed
  bdcb305

  Copy full SHA for bdcb305

• Refactoring - Prevent inet_pton from emitting a warning

  nibra

  committed
  cfabc8e

  Copy full SHA for cfabc8e

• Style - Add comments

  nibra

  committed
  4a6c287

  Copy full SHA for 4a6c287

• Style - Add CS fixes

  nibra

  committed
  fdc29aa

  Copy full SHA for fdc29aa

Commits on Apr 2, 2021

• Refactoring - Re-add IPinList() as proxy for isInRanges()

  nibra

  committed
  c62f29d

  Copy full SHA for c62f29d

Commits on Apr 8, 2021

• Refactoring - Follow early return pattern, allow REMOTE_ADDR be set in environment

  nibra

  committed
  119b8d0

  Copy full SHA for 119b8d0