[Feature] RFC1738 compliant URL Parsers #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nibra still a WIP or ready? what are the next steps? |
|
It needs joomla-framework/utilities#31 to be accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP parse_url function is very basic and does not follow RFC 1738, which defines the syntax of URLs.
The parsers implemented in this PR are modelled after the BNF in section 5 of that RFC, so they are much more precise.
Summary of Changes
Testing Instructions
Replace the Uri package in an installation with this and make sure that everything works as expected.
Documentation Changes Required
Yes, WIP