This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Develop #360
Open
Develop #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split render method, with renderNode added to render an individual node - Resolved test issues with expand collapse functions
- The class node-selected is added via setSelectedState - Removed inline style that sets color + background-color based on selected state - Updated injected css to use options selectedColor + selectedBackColor - Allows of user override via .css resource
…ange in state #76
…s only changes in results are now set/unset #76
…n-immediate children out of position (at the end) #76 - Added state.visible which controls whether a node is visible or not (display:none) and refactored to render all nodes all the time
… setInitialStates). Fixes #96
…thods. Closes #134
* feature/219-remove-hyperlink-support: Update doc to remove enableLinks and node.href usage Remove demo Remove hyperlink support
* feature/173-prevent-unselect:
Update doc to include preventDefault usage
Tests
Prevent node from being unselected when option preventUnselected true
closes #173
- Replaced getNode() with findNodes() which allows querying of nodes by any value - Replaced getParent() with getParents() which accepts multiple nodes (array)
…nstead of optional identifiers (confusing)
* feature/103-find-nodes: Simplified all methods to accept only nodes (Array of node objects) instead of optional identifiers (confusing) Refactor node query logic - Replaced getNode() with findNodes() which allows querying of nodes by any value - Replaced getParent() with getParents() which accepts multiple nodes (array) Documented proposed method Completes #103
* feature/228-lifecycle-events:
Add lifecycle event demo
Fix missing event options to silence events during initialization
Implement basic lifecycle events - initialised, nodeRendered, rendered, destroyed
Update README with proposed changes
Closes #228
* feature/39-remote-data-requests:
Tidy
Update lifecycle events to include new events: loading, loadingFailed
Update demo examples to include loading remote data
Add load remote data using dataUrl and jQuery Ajax
Tests
Document proposed changes i.e. dataUrl
Closes #39
- needed for addNodes(nodes, parentNode, index, options)
* feature/50-add-update-remove-nodes: Tidy Documented additional method; getNodes Ensure all API methods accept nodes as either a single node or an array of nodes. Implemented removeNode, updateNode Implemented addNodeAfter, addNodeBefore Implemented addNodes Refactor initialisation and rendering to support proposed node method Add index (relative to siblings) to node properties - needed for addNodes(nodes, parentNode, index, options) Documented proposed changes Completes #50
Resolves #223
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
It s a good work.
Yes it works with bootstrap4 well just change icon style.