Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed parent form search to allow arbitrary parent distances. #100

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

paulbalomiri
Copy link

solution to #99 (just the distance < 6 removal part)

…Error because it is using EJSON.stringify on the SimpleSchema which fails when simpleSchema has a validation context (contains circular reference)
@jonjamz
Copy link
Owner

jonjamz commented Mar 20, 2016

First commit seems cool, I need to look at it more in a bit. The second commit has something I don't recognize--data.string--is this something you're using personally?

@paulbalomiri
Copy link
Author

sorry, no
data schema
i'm going to correct that (i did, but did not push, sorry)

… options.

  - refactored into details:
    - dotNotationToValue
    - dotNotationToObject
    - deleteByDotNotation
    - deepExtendObject
- Changed deepExtendObject to also accept arrays for deep extensions
- moved reactiveForms setting in CreatedFactory to before init, as customizing the refactored store variables might need access to it
…w for parent forms to submit children first and continue their submission process afterwards.
@paulbalomiri
Copy link
Author

These changes allow for customizing of the store. From the comments i understand that you are planning a store package?

The next changes will make arrays available, as my current implementation hacks around the problem by using subforms for each array member.

The problem: one validation context for all array.$.member
I think the way to go forward is to introduce data paths and schema paths where data paths are resolved into schema paths using info from the template instance.

Update: The schemaContext of each element should validate only the array element it represents

Part of it proposed in #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants