added new origin factor feature #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaysmalia
commented
Oct 10, 2020
| // Events | ||
| this.onMouseEnter = this.onMouseEnter.bind(this, this.props.onMouseEnter); | ||
| this.onMouseMove = this.onMouseMove.bind(this, this.props.onMouseMove); | ||
| this.onMouseLeave = this.onMouseLeave.bind(this, this.props.onMouseLeave); | ||
| } | ||
| componentDidMount() { | ||
| this.element = findDOMNode(this); | ||
| const myNode = this.getDOMNode(); | ||
| const myNode = this.element |
There was a problem hiding this comment.
changed it because it is causing the build to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
origin factor feature
Had an idea for adding a customisable origin factor feature.
the idea is very simple, by default, the tilt origin is from center, I needed a different origin, maybe from bottom, or the left side or maybe somewhere between center and top, so I created a solution for this problem.
I added two options:
XOrigin(default 0) andYOrigin(default 0).the range for both is from -1 to 1, -1 is the very start of the axis and 1 is the end of the axis, of course the default (0) is the center of the axis.
usage:
(by the way i dont now how to delete the package-lock.json file from the commits so you can just delete it)