Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move docker related stuff to docker namespace #278

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Move docker related stuff to docker namespace #278

merged 2 commits into from
Feb 24, 2024

Conversation

welcoMattic
Copy link
Contributor

  • Merge utils.php and infra.php into docker.php
  • Move infra namespace to docker namespace

@welcoMattic welcoMattic force-pushed the docker-namespace branch 4 times, most recently from 38a276a to 48f0556 Compare February 20, 2024 10:18
@welcoMattic welcoMattic requested review from lyrixx and pyrech February 20, 2024 10:20
lyrixx
lyrixx reviewed Feb 20, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lyrixx
lyrixx approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initial for @welcoMattic ; I finished your PR.

@lyrixx lyrixx merged commit f2b672f into main Feb 24, 2024
4 checks passed
@lyrixx lyrixx deleted the docker-namespace branch February 24, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@pyrech pyrech Awaiting requested review from pyrech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@welcoMattic @lyrixx