Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically replace hostnames in the README #250

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Automatically replace hostnames in the README #250

merged 1 commit into from
Oct 25, 2023

Conversation

JorickPepin
Copy link
Member

@JorickPepin JorickPepin commented Oct 25, 2023 •
edited
Loading

This automatically replaces <your hostnames> in the domain configuration command by the domains define in the default parameters when executing castor init task.

e.g. :

echo '127.0.0.1 app.test www.app.test' | sudo tee -a /etc/hosts

instead of

echo '127.0.0.1 <your hostnames>' | sudo tee -a /etc/hosts

@JorickPepin JorickPepin added the enhancement New feature or request label Oct 25, 2023
lyrixx
lyrixx approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart. I like it. Thanks

@lyrixx lyrixx merged commit 9e4eac7 into main Oct 25, 2023
3 checks passed
@lyrixx lyrixx deleted the hostnames branch October 25, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorickPepin @lyrixx