New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config: Remove support for "project_directory" #243

Closed

lyrixx wants to merge 1 commit into main from you-wont-like-it-but-its-much-better

Member

lyrixx commented Oct 7, 2023 •

edited

Loading

On all my personnal projects I applied this patch, it's much more simpler and I love it!

Remove the hack with the "root" mounting point
does not require to configure the working dir, or the config file (see diff in qa.php)
path are simpler when copy pasting things from git diff: If I open my IDE in application, I cannot copy the path from git since it contains the application prefix, but IDE does not know about it.
see the diff since :)

I'm pretty sure some of you will be against it, but honnestly, it's better, simpler, and more standard layout.

Then, we had this layout to support multi application, multi kernel etc... And most the application we build
are regular (mono) application.

As this project is a starter, it must reflects the most common case. So let's simplify that 😃

I hope you'll approve it 🤞


          Config: Remove support for "project_directory"

cff2ea7

Member Author

lyrixx commented Oct 9, 2023

We talked about this internally, and nobody agree with this PR. I'm closing it

lyrixx closed this

lyrixx deleted the you-wont-like-it-but-its-much-better branch

October 9, 2023 13:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet