feat(mapper): allow to merge existing values by extracting identifiers #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/merge-existing-value-with-identifier
branch
from
f57c1f9 to
d33b20f
Compare
joelwurtz
force-pushed
the
feat/merge-existing-value-with-identifier
branch
from
171675c to
0979712
Compare
joelwurtz
force-pushed
the
feat/merge-existing-value-with-identifier
branch
from
745cb5b to
12a3e45
Compare
Korbeil
reviewed
Apr 7, 2025
| private readonly string $property, | ||
| private readonly bool $private = false, | ||
| public readonly string $property, | ||
| public readonly bool $private = false, | ||
| public readonly ?\ReflectionParameter $parameter = null, | ||
| private readonly ?string $removeMethodName = null, |
There was a problem hiding this comment.
Can't we pass this as public as well ? Since it's readonly there is no point letting it alone as private.
| $itemStatements[] = new Stmt\Expression(new Expr\Assign($mappedValueVar, $output)); | ||
| $itemStatements[] = new Stmt\If_(new Expr\BinaryOp\NotIdentical(new Expr\ConstFetch(new Name('null')), $mappedValueVar), [ | ||
| 'stmts' => [ | ||
| new Stmt\Expression($propertyMapping->target->writeMutator->getExpression($target, $mappedValueVar, $assignByRef)), | ||
| ], | ||
| ]); | ||
|
|
||
| // @TODO handle existingValue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce the possibility to deep merge object with collections and fetching the correct value to update it instead of adding a new one into the collection