Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(i18n): remove unused translations #832

Merged
merged 4 commits into from
Sep 4, 2024
Merged

chore(i18n): remove unused translations #832

merged 4 commits into from
Sep 4, 2024

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Sep 4, 2024 •
edited
Loading

Follow-up to #830.

  • Removes unused translations
  • Fixes the Settings page unit test
  • Run GitHub workflows on devel branch

@theborakompanioni theborakompanioni added the i18n Issues related to translation and internationalisation (i18n) label Sep 4, 2024
@theborakompanioni theborakompanioni self-assigned this Sep 4, 2024
@theborakompanioni theborakompanioni marked this pull request as ready for review September 4, 2024 09:18
MarnixCroes
MarnixCroes approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@theborakompanioni theborakompanioni requested review from MarnixCroes and removed request for MarnixCroes, barrytra and amitx13 September 4, 2024 09:53
@theborakompanioni theborakompanioni merged commit bbf72b9 into devel Sep 4, 2024
1 check passed
@theborakompanioni theborakompanioni deleted the chore/cleanup branch September 4, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarnixCroes MarnixCroes MarnixCroes approved these changes

Assignees

@theborakompanioni theborakompanioni

Labels
i18n Issues related to translation and internationalisation (i18n)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theborakompanioni @MarnixCroes