Fix to_chars_static buffer size #1026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmcfarlane
force-pushed
the
fix-to_chars_static-buffer-size
branch
7 times, most recently
from
5f75b2a
to
d35f5a8
Compare
johnmcfarlane
force-pushed
the
fix-to_chars_static-buffer-size
branch
from
d35f5a8
to
e6df31b
Compare
added 2 commits
May 27, 2022 22:58
- assumed decimal - sometimes got it wrong - potentially got it badly wrong - now uses lookup table to ensure the right number of characters to represent in integer of a given number of binary digits - table generator: https://godbolt.org/z/sYc7v185T - correctness: ~95% - probably of causing buffer overrun: < 1%
johnmcfarlane
force-pushed
the
fix-to_chars_static-buffer-size
branch
from
e6df31b
to
e5a6d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.