-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Update extension to use event system of phpunit/phpunit:10.0.0
#98
base: master
Are you sure you want to change the base?
Conversation
ba1b4b1
to
dc9f3e2
Compare
00e07ed
to
ce30fec
Compare
ce30fec
to
c5ee59b
Compare
For those of you coming here and looking for an alternative that works with |
Any chance to be merged? |
How can I help to make this merged? |
Ping @johnkary :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"php": ">=7.2", | ||
"phpunit/phpunit": "^8.0 || ^9.0" | ||
"php": "^8.1", | ||
"phpunit/phpunit": "^10.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how feasible is to keep currently still supported phpunit 9.x together with 10.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@localheinz can it be done, please, so this dep can be used for projects that still need PHP <8.1 support
Quick update: for those of you coming here and looking for an alternative that works with
I just released |
Quick update: for those of you coming here and looking for an alternative that works with
as well as
I just released |
This pull request
phpunit/phpunit:10.0.0
, 2023Follows #83.
Related to sebastianbergmann/phpunit#4676.
πββοΈ I will talk about Extending PHPUnit with its New Event System on October 25, 2022, at the International PHP Conference 2022 (Munich)
Since this extension is one of the few that I have been using and contributed to, I would like to use this pull request to demonstrate updating an existing extension to the new event system.
You recently updated the extension from the deprecated hooks interface to using the deprecated
TestListener
(see #83).phpunit/phpunit:10.0.0
, which will be released on February 3, 2023, will remove the deprecated hooks andTestListener
extension points.To keep the diff small and understandable, I have tried to make the fewest changes possible.
I understand that there could be more work done, which I am happy to do, but I believe that this would be beyond the scope of this pull request.