Allow useNativeDriver to be passed to RewardComponent #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you have a patch-package patch you could post I could try it pretty easily |
|
I just patched it manually for testing, but if it's easier I can patch tomorrow and send you config if you want |
|
Low-priority, it was more just if you had used patch-package to do it (you can run patch-package to create the patch from your node-modules as well...), I was just thinking I could test it to qualify it more for review/merge before @johniak spent any time |
|
Hi Please merge the branch |
|
can we have this merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native now requires useNativeDriver to be passed to Animated components (see changelog). It currently issues a warning when this is missing, which breaks my app on Expo.
The change allows passing this property to the component. It defaults to true.