Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add report tests #500

Merged
merged 1 commit into from
Dec 10, 2024
Merged

add report tests #500

merged 1 commit into from
Dec 10, 2024

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Dec 10, 2024

Description

  • add report tests

Related Issue

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (0640af4) to head (5604338).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   87.09%   87.94%   +0.86%     
==========================================
  Files          61       61              
  Lines        2330     2330              
==========================================
+ Hits         2029     2049      +20     
+ Misses        268      246      -22     
- Partials       33       35       +2     
Flag Coverage Δ
unittests 87.94% <ø> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit 6923857 into master Dec 10, 2024
7 checks passed
@johnfercher johnfercher deleted the feature/unit-test-normalize branch December 10, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant