Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client: clickmanager, maplebutton, maplestancebutton, mapleframebutton #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Client: clickmanager, maplebutton, maplestancebutton, mapleframebutton #7

wants to merge 2 commits into from

Conversation

sedyn
Copy link
Contributor

@sedyn sedyn commented May 29, 2018

I implement new features.

  • MapleButton
  • MapleStanceButton: Class for button like loginButton which uses stance for drawing.
  • MapleFrameButton: Class for button like dice which uses frame for drawing.
  • ClickManager: Manage the click of button.

johncintron
johncintron reviewed Jun 10, 2018
View reviewed changes
src/client/clickmanager.js Outdated
return;
}

for (let button of buttons) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use for (const. This also applies to lines 46 and 58.

johncintron
johncintron requested changes Jun 10, 2018
View reviewed changes
Copy link
Owner

@johncintron johncintron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this PR break the login button? By that I mean hovering over it or clicking it has no effect.

Hint: there's something wrong with MapleStanceButton and getRect.

@sedyn
Copy link
Contributor Author

sedyn commented Jun 11, 2018

@johncintron Thank you for review. I fixed problem.
Also, did I use maplebutton class correctly for inheritance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncintron johncintron johncintron requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sedyn @johncintron