Skip to content

Commit

Permalink
docs: Remove FF warning in readme
Browse files Browse the repository at this point in the history
And add a note about not removing the event handler so we don't
accidentally break it again.
  • Loading branch information
johanhelsing committed Jan 13, 2023
1 parent 6ed6be3 commit bd420f6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ p2p connections in web browsers to facilitate low-latency multiplayer games.
- [Introductory blog post](https://johanhelsing.studio/posts/introducing-matchbox)
- [Tutorial for usage with Bevy and GGRS](https://johanhelsing.studio/posts/extreme-bevy)

**WARNING:** This project is in early stages, it has issues with disconnections on Firefox. Make sure to check the [list of
open issues](https://github.com/johanhelsing/matchbox/issues)

It is currently an all-in-one solution, it comes with:

- A tiny signalling server, [matchbox_server](https://github.com/johanhelsing/matchbox/tree/main/matchbox_server). Written in
Expand Down
2 changes: 2 additions & 0 deletions matchbox_socket/src/webrtc_socket/wasm/message_loop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,8 @@ fn create_rtc_peer_connection(config: &WebRtcSocketConfig) -> RtcPeerConnection
);
});
let oniceconnectionstatechange = Closure::wrap(oniceconnectionstatechange);
// NOTE: Not attaching a handler on this event causes FF to disconnect after a couple of seconds
// see: https://github.com/johanhelsing/matchbox/issues/36
connection
.set_oniceconnectionstatechange(Some(oniceconnectionstatechange.as_ref().unchecked_ref()));
oniceconnectionstatechange.forget();
Expand Down

0 comments on commit bd420f6

Please sign in to comment.